search

ContactEngineering / ContactMechanics

Contact mechanics using elastic half-space methods
https://contactengineering.github.io/ContactMechanics/
MIT License
20 stars 5 forks source link

v1.0 #66

Closed pastewka closed 2 years ago

pastewka commented 2 years ago

Pipeline function for contact mechanics (#44) plus issue from v1.0 (https://github.com/ContactEngineering/ContactMechanics/milestone/1)

pastewka commented 2 years ago

I suggest to move #22 and #28 out of v1.0 and address later as those are bigger issues. In particular #22 needs changes to muFFT that need to propagate through. We should also address #53 with those issues.

sannant commented 2 years ago

Please have a look at https://github.com/ContactEngineering/ContactMechanics/issues/38 again before merging

sannant commented 2 years ago

t.contact_mechanics? yields no docstring. That is really annoying, but I think that is part of a larger issue we are not sure how to address.

sannant commented 2 years ago

I have added a little example notebook illustrating the use of the pipeline function

sannant commented 2 years ago

I didn't go through it in very much details, but the pipeline function looks reasonable and I am fine if merge now and polish it as we use it.

pastewka commented 2 years ago

Please have a look at #38 again before merging

I've reverted my earlier change here.

pastewka commented 2 years ago

Hi @sannant - can rereview this? I've folded in changes to the mixing solver because @johanzhuohan had convergence problems, see #68

sannant commented 2 years ago

Can we add a more challenging test or long_test based on @johanzhuohan 's usecase ?