Open sitangshugk95 opened 1 year ago
@sannant
This is a mistake in the example notebook, the formulation in the docstring is ambiguous.
The "total contact area" is already the fractional contact area.
Replacing
ax.loglog(mean_pressure, total_contact_area / np.prod(t.physical_sizes), "+")
by
ax.loglog(mean_pressure, total_contact_area / np.prod(t.physical_sizes), "+")
should fix the problem:w
@pastewka , why did you call this variable like this ?
total_contact_area = (force_xy > 0).sum() / np.prod(topography.nb_grid_pts)
[ ] I suggest to rename to fractional_contact_area.
[ ] Especially in the docstring of the pipeline function ...
[ ] And update the example
I am using the example code easy_hardwall_simulation to run a simulation on my own [surface topography](Sitangshu Chatterjee. (2022). contact.engineering. Randomly Rough surface (Version 1). https://doi.org/10.57703/ce-nyq38) published on contact.engineering. However, I am getting different results for the relative contact area - they are off by an order of magnitude (images attached):
![Screenshot from 2022-11-16 13-00-42](https://user-images.githubusercontent.com/108830413/202269733-f7e7c856-2862-405e-aa91-0931e22820f8.png)
The only change I have made to the code is change the address that the container reads, as shown below:![Screenshot from 2022-11-16 13-06-02](https://user-images.githubusercontent.com/108830413/202270728-be9e2651-ebe5-4131-94ca-f2d8965cd6cd.png)
Why does the website and the code give different results?