ContactEngineering / SurfaceTopography

Read and analyze surface topographies
https://contactengineering.github.io/SurfaceTopography/
MIT License
17 stars 10 forks source link

Definition of distance in scale_dependent_statistical_properties #240

Open sannant opened 1 year ago

sannant commented 1 year ago

https://github.com/ContactEngineering/SurfaceTopography/blob/cc538c9ebf77ecd81306edd570df20ef62b1b264/SurfaceTopography/Generic/ScaleDependentStatistics.py#L69-L76

Here it is clearly stated (although I don't know whether it corresponds to what we do)

But in the current documentation it says nothing:

https://contactengineering.github.io/SurfaceTopography/source/SurfaceTopography.Container.html#SurfaceTopography.Container.ScaleDependentStatistics.scale_dependent_statistical_property

Is the distance the stencil length $\ell = \eta \alpha dx$ in our paper, or just $\eta dx$ ?

sannant commented 1 year ago

Seems that it is correct in the code.

https://github.com/ContactEngineering/SurfaceTopography/blob/d189fc45479bd0d7a56243b8b700e28d0e61e017/SurfaceTopography/Generic/ScaleDependentStatistics.py#L69-L76

I think that the problem is that the documentation is not up to date.