search

ContainX / marathon-ldap

LDAP / Active Directory Authentication and Authorization Plugin for Mesosphere Marathon
Other
60 stars 32 forks source link

LDAP flexibility #2

Closed davison closed 8 years ago

davison commented 8 years ago

I've made it more amenable to a number of different schemas and server setups, at the cost of some additional complexity for the user configuring the ldap section of plugin-conf.json. I've annotated the config in README.md to hopefully ease this.

Unfortunately I can only test this with different setups that I have here and can't easily verify that something I've done has irreversibly broken what was previously working in whichever particular environments this was written against :). I'd suggest merging to a test branch and seeing if we can make it work against your server.

gondor commented 8 years ago

This looks great! Let me spend a day testing this against a couple alternate environments as well as Active Directory. I like how you pulled out the internals into the global configuration. Good work @davison

davison commented 8 years ago

@gondor sounds good.. let me know if I can help with anything.