search

ContainX / openstack4j

A Fluent OpenStack SDK / Client Library for Java
http://openstack4j.com
Other
290 stars 368 forks source link

we want to contribute some change about neutron classes #1023

Open JackSunshine opened 7 years ago

JackSunshine commented 7 years ago

Hi all, we are using openstack4j during developing apps of SDN Controller ONOS, there are some issues we found we want to discuss and fix,

  1. we don't understand why some functions return the type <? extends T>, it will cause we must abuse extend list in our code, it's not good. here we want to know, Is there any reason openstack4j keep this kind of return type?
  2. many Neutron classes only contain some of the attributes defined in openstack api, for example, the NeutronNetwork doesn't have mtu field and other elements, For about builder implementation, I’m not sure why but openstack4j classes provides builder but only for some of the attributes.

Hi @auhlig can you point me out here? we would like to contribute some code if necessary. Thanks.

auhlig commented 7 years ago

Hey @JackSunshine, Thanks for filing the issue. Contributions are always welcome :)

  1. Could you be more specific on your 1st question?
  2. I guess it's the nature of open-source projects that every contributor does just the parts he actually needs. So, as I mentioned in the beginning, if there's anything missing feel encouraged to submit a tested fix.