search

ContainerSolutions / externalsecret-operator

An operator to fetch secrets from cloud services and inject them in Kubernetes
Apache License 2.0
189 stars 28 forks source link

Fix Typo, Corrected Vocabulary and grammar #109

Closed archit041198 closed 4 years ago

archit041198 commented 4 years ago

Fix Typo, Corrected Vocabulary and grammar.

archit041198 commented 4 years ago

@frankscholten @amouat Please, let me know any changes. I will be happy to update this PR.

codecov[bot] commented 4 years ago

Codecov Report

Merging #109 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #109   +/-   ##
=======================================
  Coverage   85.44%   85.44%           
=======================================
  Files           9        9           
  Lines         261      261           
=======================================
  Hits          223      223           
  Misses         28       28           
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2278d13...c2c79fb. Read the comment docs.

knelasevero commented 4 years ago

Thanks @archit041198 ! We do appreciate all attempts to update our docs. I'm not sure if this is related to Hacktoberfest, but I've labelled this issue as invalid. As per the HacktoberFest guidelines, we do not accept minor text fixes as a qualifying PRs. I'm still happy to merge this, but I first wanted to warn you that it won't count for HacktoberFest. If you'd really like to get involved in this project, or any Container Solutions project, please take a look for issues labelled hacktoberfest or good-first-issue.