Builds on branches failing

ContainerSolutions / externalsecret-operator

An operator to fetch secrets from cloud services and inject them in Kubernetes

Apache License 2.0

189 stars 28 forks source link

Closed knelasevero closed 4 years ago

knelasevero commented 4 years ago

@dbirks Now builds on PRs work, but not on branches :(

I think that we first need to test if the event name is pull_request to be able to only do that name check on pull resquests.

Wanna take care of this one?

dbirks commented 4 years ago

Whoops, missed that. Yes I'll give it a shot :+1:

dbirks commented 4 years ago

Rats, looks like even without the 2nd if statement being run, it becomes an invalid conditional :confounded:

    if [[  != ContainerSolutions/externalsecret-operator ]]; then
...
line 20: conditional binary operator expected

I'll have to think about that...

knelasevero commented 4 years ago

@dbirks :thinking: since it is template substitution I think you can just

REPO_FULL_NAME="${{ github.event.pull_request.head.repo.full_name }}"

And then it will always be "" even if its empty.

dbirks commented 4 years ago

Hey you're right, I tested it out locally and that works :+1: One last PR...