search

ContainerSolutions / externalsecret-operator

An operator to fetch secrets from cloud services and inject them in Kubernetes
Apache License 2.0
189 stars 28 forks source link

Include our op module fork #129

Closed knelasevero closed 3 years ago

knelasevero commented 3 years ago

We had to create a fork of the 1password wrapper module to adapt it to work with new versions of op cli. This PR adds the fork as a dependency instead of the original one.

codecov[bot] commented 3 years ago

Codecov Report

Merging #129 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #129   +/-   ##
=======================================
  Coverage   88.44%   88.44%           
=======================================
  Files          10       10           
  Lines         372      372           
=======================================
  Hits          329      329           
  Misses         30       30           
  Partials       13       13
Impacted Files Coverage Δ
pkg/onepassword/op.go 79.16% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b3a2bb9...ab02fc3. Read the comment docs.

jonatasbaldin commented 3 years ago

Hey mate, thanks for the PR!

We can also update the ONEPASSWORD_CLI_VERSION to v1.8.0 on the Dockerfile

knelasevero commented 3 years ago

Hey mate, thanks for the PR!

We can also update the ONEPASSWORD_CLI_VERSION to v1.8.0 on the Dockerfile

That's true!

knelasevero commented 3 years ago

/approve

knelasevero commented 3 years ago

/merge