ContainerSolutions / externalsecret-operator

An operator to fetch secrets from cloud services and inject them in Kubernetes
Apache License 2.0
189 stars 28 forks source link

Gitlab backend #131

Closed jonathangold closed 3 years ago

jonathangold commented 3 years ago

This PR adds a gitlab backend. Still work in progress, will ping someone for review when it's ready.

codecov[bot] commented 3 years ago

Codecov Report

Merging #131 (a72a959) into master (ff7cc01) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #131   +/-   ##
=======================================
  Coverage   87.93%   87.93%           
=======================================
  Files           8        8           
  Lines         315      315           
=======================================
  Hits          277      277           
  Misses         25       25           
  Partials       13       13           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ff7cc01...7b4b10d. Read the comment docs.

jonathangold commented 3 years ago

@knelasevero The docker stage is failing at

#42 [linux/arm/v7 stage-1 1/4] FROM gcr.io/distroless/base-debian10:latest
#42 resolve gcr.io/distroless/base-debian10:latest 0.1s done
#42 ERROR: no match for platform in manifest: not found

https://github.com/ContainerSolutions/externalsecret-operator/pull/131/checks?check_run_id=1370440971#step:7:86 I don't think it's any of my changes. Have you seen this before?

Edit: Resolved by #133

jonatasbaldin commented 3 years ago

Thanks for all the replies @jonathangold!

We just merged the removal of the 1Password backend and legacy code... could u rebase this branch too? ✨

Thanks ❤️

jonathangold commented 3 years ago

@jonatasbaldin Thanks for the review! I made the changes you pointed out. Just need to validate the api permissions are enough.

knelasevero commented 3 years ago

/approve