search

ContainerSolutions / externalsecret-operator

An operator to fetch secrets from cloud services and inject them in Kubernetes
Apache License 2.0
189 stars 28 forks source link

Adding credstash backend #140

Closed knelasevero closed 3 years ago

knelasevero commented 3 years ago

Adding credstash backend heavily based on ouzi-dev/credstash-operator.

codecov[bot] commented 3 years ago

Codecov Report

Merging #140 (722becb) into master (943f9d9) will decrease coverage by 10.29%. The diff coverage is 31.64%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #140       +/-   ##
===========================================
- Coverage   80.85%   70.55%   -10.30%     
===========================================
  Files           9       10        +1     
  Lines         350      411       +61     
===========================================
+ Hits          283      290        +7     
- Misses         53      104       +51     
- Partials       14       17        +3
Impacted Files Coverage Δ
pkg/utils/utils.go 26.47% <0.00%> (-26.48%) :arrow_down:
pkg/credstash/backend.go 39.34% <39.34%> (ø)
pkg/asm/backend.go 84.37% <100.00%> (-5.43%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 943f9d9...2c1196f. Read the comment docs.

knelasevero commented 3 years ago

Just leaving the draft up here. Will get back to it when I have time to write the tests and properly manually try things. I can still get feedback if someone has some :smile:

knelasevero commented 3 years ago

i am going to merge this since it is taking a long time to get merged (my fault :sweat_smile: ). After we are confortable with all the backends that got integrated on master we can prepare to launch another release!

knelasevero commented 3 years ago

/approve

knelasevero commented 3 years ago

/label merge