ContainerSolutions / externalsecret-operator

An operator to fetch secrets from cloud services and inject them in Kubernetes
Apache License 2.0
189 stars 28 forks source link

Remove `---` from status keys in CRD yaml specs (Fixes #152) #156

Closed DylanGuedes closed 3 years ago

DylanGuedes commented 3 years ago

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

No

How was this patch tested?

I validated in my local fork that doc.crds.dev is parsing fine with the new changes

codecov[bot] commented 3 years ago

Codecov Report

Merging #156 (524ff9a) into master (f04c967) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #156   +/-   ##
=======================================
  Coverage   70.55%   70.55%           
=======================================
  Files          10       10           
  Lines         411      411           
=======================================
  Hits          290      290           
  Misses        104      104           
  Partials       17       17           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f04c967...8c21cab. Read the comment docs.

knelasevero commented 3 years ago

Hey Thanks for your contribution, but this happens due to a bug on the docs.crd tool. Since these "---" are generated by our make manager, we would end up with them again. Better to wait for the fix on docs.crd :)

Saw that you closed the PR. Thanks anyway! We appreciate the intention, and you can grab another issue if you want! :smiley: