ContainerSolutions / externalsecret-operator

An operator to fetch secrets from cloud services and inject them in Kubernetes
Apache License 2.0
189 stars 28 forks source link

WIP - Replace vendor directories with modules #76

Closed frankscholten closed 5 years ago

codecov[bot] commented 5 years ago

Codecov Report

Merging #76 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #76   +/-   ##
=======================================
  Coverage   57.71%   57.71%           
=======================================
  Files           7        7           
  Lines         201      201           
=======================================
  Hits          116      116           
  Misses         77       77           
  Partials        8        8
Impacted Files Coverage Δ
...roller/externalsecret/externalsecret_controller.go 0% <ø> (ø) :arrow_up:
secrets/asm/backend.go 53.84% <ø> (ø) :arrow_up:
secrets/onepassword/backend.go 81.81% <ø> (ø) :arrow_up:
...troller/externalsecret/externalsecret_functions.go 84.61% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9c243c1...4b1b263. Read the comment docs.

frankscholten commented 5 years ago

The second build fails on CircleCI. It runs operator-sdk build containersol/externalsecret-operator but cannot find the externalsecret-operator binary. Locally the build works fine.

I don't understand what is going wrong.

@riccardomc Do you have an idea?


Step 5/12 : COPY build/_output/bin/externalsecret-operator ${OPERATOR}
COPY failed: stat /var/lib/docker/tmp/docker-builder729928230/build/_output/bin/externalsecret-operator: no such file or directory
Error: failed to output build image containersol/externalsecret-operator: (failed to exec []string{"docker", "build", "-f", "build/Dockerfile", "-t", "containersol/externalsecret-operator", "."}: exit status 1)
Usage:
  operator-sdk build <image> [flags]

Flags:
      --go-build-args string      Extra Go build arguments as one string such as "-ldflags -X=main.xyz=abc"
  -h, --help                      help for build
      --image-build-args string   Extra image build arguments as one string such as "--build-arg https_proxy=$https_proxy"
      --image-builder string      Tool to build OCI images. One of: [docker, podman, buildah] (default "docker")

Global Flags:
      --verbose   Enable verbose logging

make: *** [Makefile:11: build] Error 1
Exited with code 2```
frankscholten commented 5 years ago

Build is now successful. The working_directory had to be added.

frankscholten commented 5 years ago

Found a bug in deployment.yaml. It has a hardcoded tag. Tag should be determined based on branch name.