Closed philwinder closed 8 years ago
@philwinder Looks like there's a merge conflict with Master
There is a problem with this line: https://github.com/ContainerSolutions/mesos-starter/blob/master/spring-boot-starter-mesos/src/main/java/com/containersolutions/mesos/config/autoconfigure/MesosSchedulerConfiguration.java#L169
A map isn't considered to be a present property. So when a user applies a port requirement, the port requirement isn't instantiated.
Didn't you rename it to plural ports
?
Working bridge example:
spring.application.name=kibana mesos.framework.name=kibana mesos.resources.scale=3 mesos.resources.cpus=0.5 mesos.resources.mem=256 mesos.command=kibana --port=$UI_5061 --elasticsearch http://172.17.0.2:9200 mesos.resources.ports=true mesos.resources.ports.UI_5061=ANY mesos.docker.parameter.expose=$UI_5061 mesos.docker.network=BRIDGE mesos.docker.image=kibana:latest
Documentation seems wrong? Value of $UI_5061
is the port from the Mesos Resources (i.e. 31000). To me it makes no sense to start Kibana on that port, and expose it when in Bridge mode. Normally you never touch the container ports when in Bridge mode. You just map them to $UI_5061
on the host.
Solved in #39
Working port injection. …
Working host example:
Working bridge example:
Working jar mode:
Fixes #27 and #29