ContainerSolutions / minimesos

The experimentation and testing tool for Apache Mesos - NO LONGER MAINTANED!
https://www.minimesos.org
Apache License 2.0
427 stars 61 forks source link

Set unique hostname constraints for Weave Scope #374

Closed errordeveloper closed 8 years ago

frankscholten commented 8 years ago

LGTM

Thanks @errordeveloper!

Approved with PullApprove

remmelt commented 8 years ago

What does this fix?

errordeveloper commented 8 years ago

@remmelt it's to ensure that when user scales Scope there will be only one instance of Scope per host. There is more that needs to be done around probe discovery in multi-node setup, but this is a starting point.

sadovnikov commented 8 years ago

Approved

This change will have effect only after updating https://github.com/ContainerSolutions/minimesos/blob/master/minimesos/src/main/java/com/containersol/minimesos/main/CommandInit.java. Therefore #375 is created

Approved with PullApprove

remmelt commented 8 years ago

Awesome, thanks!

Groeten,

Remmelt


On 5 Apr 2016 14:41 +0200, Viktor Sadovnikovnotifications@github.com, wrote:

Merged#374(https://github.com/ContainerSolutions/minimesos/pull/374).

— You are receiving this because you were mentioned. Reply to this email directly orview it on GitHub(https://github.com/ContainerSolutions/minimesos/pull/374#event-615108014)