search

ContainerSolutions / minimesos

The experimentation and testing tool for Apache Mesos - NO LONGER MAINTANED!
https://www.minimesos.org
Apache License 2.0
429 stars 61 forks source link

#433. There is no need to enforce --mapPortsToHost parameter on MAC #463

Closed sadovnikov closed 8 years ago

sadovnikov commented 8 years ago

Mapping of ports is needed when docker-machine is used and docker host is not added to the routing table. This is not MAC specific

frankscholten commented 8 years ago

Thanks @sadovnikov. Should we add code to detect Docker Machine usage and enable --mapPortsToHost?

frankscholten commented 8 years ago

Never mind. Let's not enforce this because people can choose to use routes or enable --mapPortsToHost.

frankscholten commented 8 years ago

LGTM

Approved with PullApprove

sadovnikov commented 8 years ago

Can we simply leave enabling mapPortsToHost up to the user? On Tue, 5 Jul 2016 at 13:38, Frank Scholten notifications@github.com wrote:

Merged #463 https://github.com/ContainerSolutions/minimesos/pull/463.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ContainerSolutions/minimesos/pull/463#event-712881860, or mute the thread https://github.com/notifications/unsubscribe/AEh4FCGdZMkZa7Lc6Mt8t072fajkivk4ks5qSkI4gaJpZM4IxZlY .

Viktor Sadovnikov Software Development Process Engineer @ JV-ration

frankscholten commented 8 years ago

@sadovnikov Yes that's what we are doing now.