ContainerSolutions / minimesos

The experimentation and testing tool for Apache Mesos - NO LONGER MAINTANED!
https://www.minimesos.org
Apache License 2.0
429 stars 61 forks source link

Add minimesos-docker version to minimesos images #475

Closed frankscholten closed 8 years ago

frankscholten commented 8 years ago

The images from https://github.com/ContainerSolutions/minimesos-docker are not versioned in the same way as minimesos is. This can cause problems because it's not clear how a specific version of minimesos is tied to a specific Docker image from minimesos-docker.

These image tags should be structured like $MINIMESOSVERSION$MESOS_VERSION such as 0.9.1-0.28.1-2.0.20.ubuntu1404 instead of just 0.28.1-2.0.20.ubuntu1404

In order to do this the minimesos version, either commit or release version, has to be known at buildtime and runtime. See https://github.com/ContainerSolutions/minimesos/issues/99

Once that is done the code from https://github.com/ContainerSolutions/minimesos-docker can be put into a separate module into minimesos.

After this the release process should be changed so a release will build, tag and push all the images related to a given minimesos release.

frankscholten commented 8 years ago

After dicussing with @sadovnikov and @adam-sandor the plan is as follows:

Change the image names in https://github.com/ContainerSolutions/minimesos-docker so that they include the Mesos version, for instance: containersol/mesos-agent-0.28.1 and then create a proper semantic version as a tag. The full container name + version becomes

containersol/mesos-agent-0.28.1:0.1.0

frankscholten commented 8 years ago

Reopening because we will instead put the Mesos and minimesos version in the tag like this

containersol/mesos-agent:0.28.1-0.1.0