Plugin does not work if docker uses TLS

ContainerSolutions / minimesos

The experimentation and testing tool for Apache Mesos - NO LONGER MAINTANED!

https://www.minimesos.org

Apache License 2.0

429 stars 61 forks source link

Plugin does not work if docker uses TLS #534

Open Igosuki opened 7 years ago

Igosuki commented 7 years ago

I can change the code to make tls verify a condition if you want

frankscholten commented 7 years ago

@Igosuki Thanks for this PR! The build fails however because of a failing test. See https://travis-ci.org/ContainerSolutions/minimesos/builds/233244362?utm_source=github_status&utm_medium=notification. Run gw clean build integrationTest to run all the tests.

frankscholten commented 7 years ago

@Igosuki It seems that now the Docker client is configured to always use TLS verification. Can you change the code so it only does this when the DOCKER_CERT_PATH env var is set? That way people who don't set up TLS verification won't get any errors.

Igosuki commented 6 years ago

Alright looks like it's still not passing for some reason, will check later