Add eks fargate example with spot control plane

ContainerSolutions / terraform-examples

Simple and idiomatic examples of various Terraform functions and features.

https://containersolutions.github.io/terraform-examples/

160 stars 51 forks source link

Add eks fargate example with spot control plane #11

Closed knelasevero closed 3 years ago

knelasevero commented 3 years ago

Opening this as an early draft since I was messign around with it for a personal project this weekend. Things that I will probably need to go over:

[ ] Naming scheme
[x] Directory structure
[x] I did some changes when copying this from my personal examples, did not test yet with this changes, so need to test it
[ ] Maybe include more things on the specific README
[x] Mention on Index.md

Heavily based on https://github.com/finleap/tf-eks-fargate-tmpl and https://engineering.finleap.com/posts/2020-02-27-eks-fargate-terraform/

ianmiell commented 3 years ago

Main comments are around a general principle - the examples should be as minimal as possible for the described functionality. These are not 'production-ready' examples.

knelasevero commented 3 years ago

I will try to minimize it. All these hings are there because they came from another example already. Anyways EKS tends to require way more stuff than I want every time that I check it. I will trim it when I have some time

knelasevero commented 3 years ago

@ianmiell Seems that I cannot use sub-directory tf modules, if I do lint complains about not having a run.sh in it. Should I try to include everything on the main.tf?

ianmiell commented 3 years ago

As a general principle, yes, I try and include everything within the main.tf .

If you want to demonstrate the use of a sub-directory, or it's essential for this example, we can create an exception. Let me know which way you'd like to go.

Ian

On Thu, May 13, 2021 at 11:50 AM Lucas Severo Alves < @.***> wrote:

@ianmiell https://github.com/ianmiell Seems that I cannot use sub-directory tf modules, if I do lint complains about not having a run.sh in it. Should I try to include everything on the main.tf?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ContainerSolutions/terraform-examples/pull/11#issuecomment-840478953, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVNZTL7F4GLBVF2LZG4S63TNOVHLANCNFSM44Q2EVCA .

knelasevero commented 3 years ago

Moved things to main.tf, and cleaned things a bit more :)