Universal bin/apply* bin/destroy* scripts

ContainerSolutions / terraform-examples

Simple and idiomatic examples of various Terraform functions and features.

https://containersolutions.github.io/terraform-examples/

159 stars 51 forks source link

Universal bin/apply* bin/destroy* scripts #53

Closed ttarczynski closed 3 years ago

ttarczynski commented 3 years ago

Goals:

with more and more scripts it makes sense to generalize them
reduce bash code duplication

ttarczynski commented 3 years ago

I have it ready for kubernetes provider. Todo: use generic scripts for all other provders.

ttarczynski commented 3 years ago

Done:

all examples use uniform bin/apply.sh, bin/destroy.sh scripts

sanyer commented 3 years ago

oh, it's in your fork I was looking for a branch and almost reinstalled VSCode :-D

sanyer commented 3 years ago

Looks good, I don't have any questions

sanyer commented 3 years ago

As the next improvements, we can look into the shared scripts and into apply and destroy scripts in each example. We might as well build some simple cli tool for this.

ttarczynski commented 3 years ago

I've just merged this into integration now. To double check the CI.

ttarczynski commented 3 years ago

I've forced a complete test run on integration (see this commit). Was all OK, so merging this to main.