Closed teszes closed 2 years ago
Checks not passing because of the changeme naming requirement. It is not exactly clear to me what is the point of those, doesn't being a module variable adequately signal that it should be provided as a variable?
The exact data blocks the check has a problem with BTW probably shouldn't be changed directly, only by changing the variables themselves.
Thank you @teszes for your contribution!
Just to expand a bit on the naming requirements. See the conventions documented here: README.md > Conventions
There are two main naming requirements:
changeme_
Also please check the scripts enforcing these requirements:
There's one more convention (not yet added to README):
The comments that we want to have in all examples:
# Summary:
– 1-line summary of what this example does# Documentation:
– add link to documentation before each block (terraform, provider, variable, resource, etc.)# Explanation:
– add only where some extra explanation is neededThank you @teszes for the fixes.
I've merged it to the integration
branch to run CI tests applying the azure examples:
integration
branch: https://github.com/ContainerSolutions/terraform-examples/runs/3022667473?check_suite_focus=trueOur azurerm
tests stopped working after previous change #56. I've described the issue in more detail in: #69
We need to fix #69 first, to be able to run automated CI tests before merging all the Azure pull requests.
That's cool, and see you at the meeting, I hope I can help fixing the CI
Added one small fix: https://github.com/ContainerSolutions/terraform-examples/pull/57/commits/719384efae48b556315bb7c392eae5400dc1f903 , run CI apply test on integration, and ready to merge 👍
Progress towards #50