Add Azure subscriptions and management groups

ContainerSolutions / terraform-examples

Simple and idiomatic examples of various Terraform functions and features.

https://containersolutions.github.io/terraform-examples/

159 stars 51 forks source link

Add Azure subscriptions and management groups #57

Closed teszes closed 2 years ago

teszes commented 3 years ago

Progress towards #50

teszes commented 3 years ago

Checks not passing because of the changeme naming requirement. It is not exactly clear to me what is the point of those, doesn't being a module variable adequately signal that it should be provided as a variable?

teszes commented 3 years ago

The exact data blocks the check has a problem with BTW probably shouldn't be changed directly, only by changing the variables themselves.

ttarczynski commented 3 years ago

Thank you @teszes for your contribution!

Just to expand a bit on the naming requirements. See the conventions documented here: README.md > Conventions

There are two main naming requirements:

all names that can be change by the user (resources, variables, data items) should be prefixed with changeme_
- it is to indicate to users new to terraform what bits are just names and can be changed
all names should be unique across all examples (resources, variables, data items)
- it is to enable easy mixing of code from multiple examples together

Also please check the scripts enforcing these requirements:

ttarczynski commented 3 years ago

There's one more convention (not yet added to README):

There should be comments explaining and linking to documentation
Please compare: google/google_compute_instance/simple/main.tf

The comments that we want to have in all examples:

# Summary: – 1-line summary of what this example does
# Documentation: – add link to documentation before each block (terraform, provider, variable, resource, etc.)
# Explanation: – add only where some extra explanation is needed

ttarczynski commented 3 years ago

Thank you @teszes for the fixes. I've merged it to the integration branch to run CI tests applying the azure examples:

Test definition: .github/workflows/main.yml#L128-L150
Last test run on integration branch: https://github.com/ContainerSolutions/terraform-examples/runs/3022667473?check_suite_focus=true

Our azurerm tests stopped working after previous change #56. I've described the issue in more detail in: #69

We need to fix #69 first, to be able to run automated CI tests before merging all the Azure pull requests.

teszes commented 3 years ago

That's cool, and see you at the meeting, I hope I can help fixing the CI

ttarczynski commented 2 years ago

Added one small fix: https://github.com/ContainerSolutions/terraform-examples/pull/57/commits/719384efae48b556315bb7c392eae5400dc1f903 , run CI apply test on integration, and ready to merge 👍