ContainerSolutions / terraform-examples

Simple and idiomatic examples of various Terraform functions and features.
https://containersolutions.github.io/terraform-examples/
159 stars 51 forks source link

CI test 'ProvidersAzure' stopped working #69

Closed ttarczynski closed 3 years ago

ttarczynski commented 3 years ago

After the recent change #56 our CI test ProvidersAzure stopped working. See:

Results from ProvidersAzure test:

Run /home/runner/work/terraform-examples/terraform-examples/bin/run_azurerm_examples.sh
find: ‘azurerm’: No such file or directory

The problem is caused by renaming azurerm to azure without the needed changes in CI and bin/*.sh scripts:

# egrep -r azurerm bin
bin/run_azurerm_examples.sh:source bin/get_azurerm_folders.sh
bin/apply.sh:SUPPORTED_PROVIDERS="aws|azurerm|digitalocean|google|kubernetes|linode"
bin/get_azurerm_folders.sh:AZURERM_FOLDERS="$(find azurerm | grep tf$ | xargs -n1 dirname | sed 's/^.\///')"
bin/destroy.sh:SUPPORTED_PROVIDERS="aws|azurerm|digitalocean|google|kubernetes|linode"
# egrep -r azurerm .github/workflows
.github/workflows/main.yml:        run: ${{github.workspace}}/bin/run_azurerm_examples.sh
ttarczynski commented 3 years ago

You can test it locally by running:

./bin/run_azurerm_examples.sh
teszes commented 3 years ago

This should be fixed on the integration branch, right?

teszes commented 3 years ago

What if we went back to the 1 provider - 1 folder scheme we had?

teszes commented 3 years ago

Submitted PR #70 to close this.

ttarczynski commented 3 years ago

70 merged, tests work OK.

Closing this.