ContainerSolutions / terraform-examples

Simple and idiomatic examples of various Terraform functions and features.
https://containersolutions.github.io/terraform-examples/
159 stars 51 forks source link

Add an RDS Aurora MySQL 1 Cluster instance that does not inherit configuration from the cluster. #82

Closed choilmto closed 3 years ago

choilmto commented 3 years ago
  1. final_snapshot_identifier is an optional argument for the aurora resource object. However, upon destroying the resource, it seems necessary to either provide a name for the final_snapshot_identifier or by setting skip_final_snapshot to true.

  2. Can someone unpack the note in the documentation about arguments in terraform including the username and password being stored in the raw state as plain-text.

choilmto commented 3 years ago

Instead of adding a solution for securing the login credentials, I've added some documentation in the terraform file to keep the module simple.

ttarczynski commented 3 years ago

Instead of adding a solution for securing the login credentials, I've added some documentation in the terraform file to keep the module simple.

It makes sense that way. I production setup we don't want to pass secrets this way because they are then stored in the tfstate file. But for our examples it's what we want (for simplicity).