submitting aws_db_instance example - Githubissues

ContainerSolutions / terraform-examples

Simple and idiomatic examples of various Terraform functions and features.

https://containersolutions.github.io/terraform-examples/

159 stars 51 forks source link

submitting aws_db_instance example #87

Closed rodrigorras closed 3 years ago

rodrigorras commented 3 years ago

Hey @ttarczynski , This is my second Pull Request for AWS db_instance (SQL).

Link related issues: Progress towards #48

Check to list SQL Database

Changes/added features:

Added a working example of RDS Databases with MySQL
Explanations pointing to AWS docs for more info

The following short checklist should be used to make sure your PR is of good quality, and can be merged easily:

[x] follows project conventions
[x] follows project principles
[x] ./run.sh works correctly for all new examples
[x] CI checks pass
[x] mergeable to main (no conflicts)
[x] resolved issues linked

Reviewers: @ianmiell @ttarczynski @sanyer

ttarczynski commented 3 years ago

CI pass on integration: https://github.com/ContainerSolutions/terraform-examples/actions/runs/1101480143