Closed ttarczynski closed 2 years ago
Looks good except the folder renaming is swapped. I think it should be from
aws/aws_aurora/cluster
toaws/aws_rds_cluster
and fromaws/aws_dynamodb/table
toaws/aws_dynamodb_table
.
Thanks @choilmto I've just double checked what happened with these folder names. It seems the folders are actually correct in this branch:
# find aws -name main.tf | xargs egrep 'aws_dynamodb_table|aws_rds_cluster'
aws/aws_dynamodb_table/simple/main.tf:resource "aws_dynamodb_table" "changeme_aws_dynamodb_table" {
aws/aws_rds_cluster/simple/main.tf:resource "aws_rds_cluster" "changeme_aws_aurora_cluster" {
So it's rather just GitHub displaying the renames for the bash scripts mixed (because the contents are identical):
0 aws/aws_aurora/cluster/destroy.sh → aws/aws_dynamodb_table/simple/destroy.sh
0 aws/aws_dynamodb/table/main.tf → aws/aws_dynamodb_table/simple/main.tf
0 aws/aws_aurora/cluster/run.sh → aws/aws_dynamodb_table/simple/run.sh
0 aws/aws_dynamodb/table/destroy.sh → aws/aws_rds_cluster/simple/destroy.sh
0 aws/aws_aurora/cluster/main.tf → aws/aws_rds_cluster/simple/main.tf
0 aws/aws_dynamodb/table/run.sh → aws/aws_rds_cluster/simple/run.sh
Link related issues:
Changes/added features:
The following short checklist should be used to make sure your PR is of good quality, and can be merged easily:
./run.sh
works correctly for all new examplesReviewers: @ianmiell @ttarczynski @sanyer