search

Contao3-Ninja / visitors

Contao Module Visitors
http://contao.ninja/visitors.html
GNU Lesser General Public License v3.0
0 stars 0 forks source link

[Insight] Methods and properties visibility should always be explicitely defined #208

Closed BugBuster1701 closed 7 years ago

BugBuster1701 commented 8 years ago

in classes/ModuleVisitorBrowser3.php, line 217

This method has no explicit visibility which may lead to maintenability issues. You should always declare a visibility for methods and properties.

    /**
    * Check to see if the specific browser is valid
    * @param string $browserName
    * @return True if the browser is the specified browser
    */
    function isBrowser($browserName) { return( 0 == strcasecmp($this->_browser_name, trim($browserName))); }

    /**
    * The name of the browser.  All return types are from the class contants
    * @return string Name of the browser
    */

Posted from SensioLabsInsight