search

ContentMine / getpapers

Get metadata, fulltexts or fulltext URLs of papers matching a search query
MIT License
197 stars 37 forks source link

Hyperlink DOIs against preferred resolver #173

Closed katrinleinweber closed 6 years ago

katrinleinweber commented 6 years ago

Hello :-)

The DOI foundation recommends this new resolver. Yes, a bit ironic, but it's now encrypted and the old links with the dx subdomain continue to work.

So, there is no urgent need to do anything, but nonetheless, I'd like to suggest to hereby update the code that generates new ones.

Cheers!

katrinleinweber commented 6 years ago

PS: Because there can basically be 4 DOI URL variants, the reg-ex in https://github.com/ContentMine/phylotree/blob/efa09c1f0a2e8bd50022788529e66d18276fa25e/input-metadata/scraping/by-year/strip-images-ijsem.sh#L20 might need to be updated.

tarrow commented 6 years ago

Hey!

Thanks for the PR, that is awesome.

I'd be happy to merge but could you unstage the change in the test file?

katrinleinweber commented 6 years ago

Sure, done :-)

tarrow commented 6 years ago

Thanks! That's awesome.

katrinleinweber commented 6 years ago

You're welcome, and thanks for merging :-)