ContentMine / getpapers

Get metadata, fulltexts or fulltext URLs of papers matching a search query
MIT License
197 stars 37 forks source link

Logger doesn't handle no output directory. #92

Closed tarrow closed 8 years ago

tarrow commented 8 years ago
tom@pisces getpapers % bin/getpapers.js -f log.xml -q aardvark -n
info: Saving logs to ./undefined/log.xml
error: No output directory given. You must provide the --outdir argument.
tarrow commented 8 years ago

Interestingly, we find that the logger writes asynchronously so if there is a log delay before changing to the output directory the log is actually written to the current directory anyway.

You can see this if you put a 5s setTimeout before changing directory

tarrow commented 8 years ago

This is now fixed as of PR #93