search

ContentSquare / chproxy

Open-Source ClickHouse http proxy and load balancer
https://www.chproxy.org/
MIT License
1.29k stars 258 forks source link

add metrics for proxy #407

Closed NatSau02 closed 7 months ago

NatSau02 commented 9 months ago

Description

(https://github.com/ContentSquare/chproxy/issues/406)

Pull request type

Please check the type of change your PR introduces: - [ ] Bugfix - [x] Feature - [ ] Code style update (formatting, renaming) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] Documentation content changes - [ ] Other (please describe): ### Checklist - [ ] Linter passes correctly - [x] Add tests which fail without the change (if possible) - [ ] All tests passing - [x] Extended the README / documentation, if necessary ## Does this introduce a breaking change?

Further comments

NatSau02 commented 8 months ago

https://github.com/ContentSquare/chproxy/actions/runs/8136869333/job/22248660475?pr=407#step:3:24 linter fell on files that I didn't change, very strange

mga-chka commented 8 months ago

I'm pinging you just in case you didn't see the comments @NatSau02

NatSau02 commented 7 months ago

@mga-chka thanks for your comments, I've solved all the threads