search

ContentSquare / chproxy

Open-Source ClickHouse http proxy and load balancer
https://www.chproxy.org/
MIT License
1.24k stars 256 forks source link

add log_comment to allowedParams #432

Closed profick closed 1 month ago

profick commented 2 months ago

Description

https://github.com/ContentSquare/chproxy/issues/431

Pull request type

Please check the type of change your PR introduces: - [ ] Bugfix - [x] Feature - [ ] Code style update (formatting, renaming) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] Documentation content changes - [ ] Other (please describe): ### Checklist - [ ] Linter passes correctly - [x] Add tests which fail without the change (if possible) - [x] All tests passing - [x] Extended the README / documentation, if necessary ## Does this introduce a breaking change?

Further comments

profick commented 1 month ago

@mga-chka Hello! Can you tell me does go-test / build (pull_request) pipeline step failure blocks PR? And what is an estimate time when we can merge this?

mga-chka commented 1 month ago

the failure is due to a bug in our CI pipeline (the generation of the code coverage, which is the last step, often fails). So it's not linked to your PR. I'll merge the PR now. FYI, we're quite busy so we won't release a new version before June

profick commented 1 month ago

I'll merge the PR now. FYI, we're quite busy so we won't release a new version before June

Ok, it's fine for me. Thank you!