ContentWarnings / WebFrontend

The web frontend repository of Movie Mentor, a University of Central Florida Senior Design app project.
http://moviementor.app/
MIT License
1 stars 0 forks source link

Everything in #11 + all auth pages #12

Closed jeffreydivi closed 1 year ago

jeffreydivi commented 1 year ago

See #11 for other details.

What changed?

How was this accomplished?

Caveats

Testing

Related Issues or Work Items

11 superseded by this because I made a fucky wucky.

jeffreydivi commented 1 year ago

I'll have to rename my movie entry url, was using entry, will change to movie for consistency (and makes more sense)

👌

possible small stretch goal: add a spinning icon for when a movie/its poster hasn't loaded yet or even just the trending movie section (usually loads pretty quickly but not always and i imagine a slow wifi connection would have that effect)

Yeah, and will extend this logic to some account pages (registration takes a whole second on 100Mbps), but tbh stretch goal. Search was more important because of pagination. Image lazy-loading like that is possible but I think it's slightly tricky iirc.

I would argue that maybe we should have just one row of movies for the trending movie section for a cleaner UI. But I am open to contrasting opinions

I do disagree with you here now that I see things as they are + knowing the amount of work it will bring on.

Adam was right to point out your use of snake case but I'm okay with it since I believe most of the importers you already committed used snake case; If necessary I believe Prettier can quickly point out uses of snake case later

We can fix this later. Low-priority rn.

jeffreydivi commented 1 year ago

Okay, I forgot that <MMHappy> is not the actual vector. Do not merge until I fix this.

jeffreydivi commented 1 year ago

Also added loading indicators to a lot of things + set the profile image in the navbar via Gravatar.

jeffreydivi commented 1 year ago

Made those changes.