ContentsMayBeHot / RivalsofAetherSupervisedLearning

Training a neural network to play Rivals of Aether
GNU General Public License v3.0
2 stars 0 forks source link

Turn duplicate code sections in training/testing loops into callable functions in utls #5

Open mjsonofharry opened 6 years ago

mjsonofharry commented 6 years ago

There's loads of identical code that could be extracted.

Write tests BEFORE extracting into functions.

mjsonofharry commented 6 years ago

The duplicate code is for getting clips from a single video. e.g.

            for j in range(0, batch_x.shape[0], CLIP_LENGTH):
                x_clip = batch_x[j:j+CLIP_LENGTH]
                y_clip = batch_y[j:j+CLIP_LENGTH]
mjsonofharry commented 6 years ago

If padding clips is implemented then it should automatically check if the clip length is too short and then yield a padded clip.