search

ContextInstitute / bfcom

http://bfn.context.org
GNU General Public License v3.0
4 stars 1 forks source link

Added icon to home menu #23

Closed DavidScottBernstein closed 5 years ago

rgilman commented 5 years ago

Looks good to me!

However, I wonder, should we be establishing any CSS naming conventions at this point?

iangilman commented 5 years ago

However, I wonder, should we be establishing any CSS naming conventions at this point?

Good question!

Since we inherit so much from the systems we're building on (from Foundation to BuddyPress, etc.), I think we should attempt to work within those systems as much as possible. When we do have to extend them, we should try to do so in ways that feel simpatico with them.

Of course when we are really blazing new ground, I suppose there might be something to be said for using some sort of naming scheme that obviously sets that new code apart. I don't know, though… My intuition at the moment is to try to feel like we're part of the same system.

Anyway, good stuff to discuss!

In the case of this patch, the classes used are just what's necessary to select the desired element given the classes that WordPress already gives them.

iangilman commented 5 years ago

Meanwhile, this patch looks good. Merging :-)

@rgilman how do you want to handle deployment of new versions? Obviously this isn't a huge change, so maybe it does need deploying quite yet, but it's worth thinking about what our deployment cadence is. Perhaps once a week for starters? Once a day? Once every pull request if they happen less frequently than once a day?

iangilman commented 5 years ago

Note: after merging a pull request it's good repository hygiene to delete the branch (which I've done here); otherwise they pile up.

rgilman commented 5 years ago

I'm fine with deployment to bfn.context.org at a relatively slow pace. Once a week or once per PR whichever is less frequent sounds fine for starters. On our local dev instances though, we should likely pull from the current master each time we start any local work. @iangilman, how does that sound to you?

iangilman commented 5 years ago

Sounds good to me :-)