ContextInstitute / bfcom

http://bfn.context.org
GNU General Public License v3.0
4 stars 1 forks source link

Use SCSS #24

Open iangilman opened 5 years ago

iangilman commented 5 years ago

It would be great if we could write SCSS directly and have the site build it for us.

This looks like a potential solution:

https://wordpress.org/plugins/wp-scss/

rgilman commented 5 years ago

Would you be willing to install that on your local instance as a test? My lean at the moment is to keep the master branch and bfn.context.org using css but allow each developer to work in SCSS or not.

iangilman commented 5 years ago

Sure, I can give it a try first, but no, we all have to adopt SCSS or none of us can. SCSS gets compiled to CSS, but if anyone changes the resulting CSS, those changes will only last until the next time the SCSS gets compiled.

rgilman commented 5 years ago

Let's go with adopting SCSS. Do you have any thoughts about segmenting our SCSS into various files or shall we just start with one?

rgilman commented 5 years ago

I would, however, like the workflow to include compiling the SCSS before pushing to GitHub (master or branch). How does that sound to you?

iangilman commented 5 years ago

It's generally not a good idea to include built files in GitHub at all. It's too easy for them to get out of sync, and even if you are good about always updating them, it creates a lot of unnecessary noise in every commit. The cleanest way to do it is to have the build be a part of everyone's local process, and also part of the deploy.

As for breaking the SCSS into multiple files, yes, I'm sure we'll find a nice way to keep each file small, with styles for just one component each or something.

rgilman commented 5 years ago

I'm still not clear on the workflow. If I build locally do I then exclude the CSS files with a .gitignore?

iangilman commented 5 years ago

Yes, that's the idea. We can't do that until we have a proper build process set up for everyone, of course.

rgilman commented 5 years ago

So for now, until we get that proper build process set up for everyone, we should include the CSS in the repo?

iangilman commented 5 years ago

Correct. I'll take care of shuffling things around and make an announcement when I get it figured out.