search

ContextInstitute / bfcom

http://bfn.context.org
GNU General Public License v3.0
4 stars 1 forks source link

Add BuddyPress and bbPress theme files #27

Closed rgilman closed 5 years ago

rgilman commented 5 years ago

I’ve copied all of the BuddyPress BP-Nouveau theme files and the bbPress theme files into the bfcom theme folder so that we can modify them as needed. At some point we may go back and remove unchanged files from bfcom but I’d rather start with a complete set.

This is part of getting us to the right starting point.

I'm doing this as a PR both for record keeping and to learn new habits. :-)

iangilman commented 5 years ago

Looks good to me!

Just so I understand… All of these files were already being called via the parent theme, but now that they are here these versions are being called instead? WordPress just takes care of that automatically for us?

rgilman commented 5 years ago

Yes, WP takes care of it but the description is subtly different. The BuddyPress and bbPress templates are buried in the plugins. They aren't considered themes since they only address displaying what's associated with that plugin. Moving them into the theme (and BFCom is a parent theme) allows us to overwrite what's in the plugins. It the proper way to do customization of those templates.

iangilman commented 5 years ago

Cool, good to know! This kind of knowledge transfer is part of what's good about pull requests :-)