iangilman
commented
6 years ago Looks great!
I see you went ahead and merged it. That's fine this time, but in the future it's best to let the reviewer do the merge so they can do any last-minute validation. Instead just add a comment that says "OK, I've made the fixes" or something. :-)
Now that it's merged, you should close the associated issue: https://github.com/ContextInstitute/bfcom/issues/28
Speaking of which, it's good to link to the issue from the pull request so it's clear what it's supposed to be fixing. Next time!
Congrats on your second pull request for this project! 🎉 🎉
Added top level menu icons for Members, Groups, Resources and Blogs.