search

ContextInstitute / bfcom

http://bfn.context.org
GNU General Public License v3.0
4 stars 1 forks source link

header - recode with CSS grid #38

Closed rgilman closed 5 years ago

rgilman commented 5 years ago

The header is currently structured using the Foundation grid system. I'd like us to be consistent in using CSS grid for our layout.

As learning resources I recommend you watch this playlist (that uses Pinegrow but the concepts transcend the software) and explore A Complete Guide to Grid. There are many other learning resources for CSS grid a quick google search away.

iangilman commented 5 years ago

Go for it!

My apprentice, Sean, suggests https://css-grid.coffeecup.com/ as an interesting CSS Grid tool.

rgilman commented 5 years ago

I've got this sorted out locally but I'd like to wait for the merging of PR #36 before going further.

rgilman commented 5 years ago

Thank Sean for the reference to https://css-grid.coffeecup.com/ . The CSS Grid tool looks like a nice resource. I prefer Pinegrow, which has an equivalent CSS Grid tool (AFAIK - I haven't done a detailed comparison) plus a full toolset for all the other aspects of frontend development. Then again, it's not free. I used Pinegrow for this recode.

iangilman commented 5 years ago

👍

rgilman commented 5 years ago

Commits here and here.

Closing this as an issue.

iangilman commented 5 years ago

I'm confused about nav-bfc_top.php… Where did it come from, and what happened to the old version of the header? How is this new one hooked in?

iangilman commented 5 years ago

Also, as mentioned elsewhere, I think it should be called nav-bfc-top.php

rgilman commented 5 years ago

The new one, by whatever name, is hooked in in the same places as the old one - header.php.

iangilman commented 5 years ago

I see. I just went through the commits in the picture is clearer now. Another good reason for using a pull request next time!

rgilman commented 5 years ago

Point well taken about using a PR, which was my intention but in my rush I clicked the wrong branch.

iangilman commented 5 years ago

No worries. If you're up for changing the name to nav-bfc-top.php (and it doesn't cause any problems), please do so and then work can continue on that file.