search

ContextInstitute / bfcom

http://bfn.context.org
GNU General Public License v3.0
4 stars 1 forks source link

#33 Replaced ‘Logo’ with logo9b.svg in an <img> tag #40

Closed DavidScottBernstein closed 5 years ago

DavidScottBernstein commented 5 years ago

@iangilman I replaced the string ‘logo’ in the header with the logo image. I used an tag. Let me know if there’s a more CSSie way to do it.

rgilman commented 5 years ago

@DavidScottBernstein, please pull the new master and copy your logo work into the file that has been renamed to nav-bfc-top.php.

iangilman commented 5 years ago

This looks great. The other more CSSie way is to apply it as a CSS background-image. You'd have to add additional styling to get the width and height right again, though, so it's a bit more involved, and I don't think it's necessary in this case.

One thing for this patch: it looks like you've based it off of the version of master prior to when @rgilman switched the header to the use CSS grid (see https://github.com/ContextInstitute/bfcom/issues/38) and changed its file name (see https://github.com/ContextInstitute/bfcom/issues/37). Because of this, before it can be merged, you'll need to update to the latest master and integrate your changes into that. This may involve some merge conflict resolution. Let me know if you want to hand with that.

Fortunately this sort of thing doesn't happen very often, but it is part of life when you're working with a team. It's a lot better with Git than it was in the old days!

iangilman commented 5 years ago

@DavidScottBernstein I haven't heard from your for a few days. No rush on this, but it would be good to know you got my message (above)!

DavidScottBernstein commented 5 years ago

@iangilman Yes, I’d like some assistance with the merge and also have some questions around my next task. Do you have time for a Zoom call sometime today or tomorrow?

On Oct 2, 2018, at 9:40 AM, Ian Gilman notifications@github.com wrote:

@DavidScottBernstein https://github.com/DavidScottBernstein I haven't heard from your for a few days. No rush on this, but it would be good to know you got my message (above)!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ContextInstitute/bfcom/pull/40#issuecomment-426344700, or mute the thread https://github.com/notifications/unsubscribe-auth/AGxlMrF9beaf1dOXVhHRxkYzh1J7Bc4lks5ug5cbgaJpZM4XAMN3.

David Scott Bernstein, David@ToBeAgile.com Developer/Speaker/Trainer/Coach. Principal consultant at To Be Agile http://tobeagile.com/. Author of Beyond Legacy Code: Nine Practices to Extend the Life (and Value) of Your Software http://beyondlegacycode.com/. Stay in touch: sign up for my newsletter https://tobeagile.com/signup/, follow me on Twitter: @ToBeAgile http://twitter.com/ToBeAgile.

iangilman commented 5 years ago

Sure! I should be available today at 11 AM or after 1 PM. We can coordinate the details via Slack. :-)

iangilman commented 5 years ago

Looking good!