Match font size of page title to thread title on forum topic pages

[DavidScottBernstein]

On forum topic pages, changed the font size of page title to match font size of the thread title by styling .forum.single-item .page-title.

Fixed #50 by styling .forum.single-item .page-title so the font size of the page title matches the thread title.

[rgilman]

@DavidScottBernstein, first let me say how much I'm appreciating the way you're moving up the learning curve with all of this!

Second, I had been thinking of matching the menu font size (so 1 rem) and then enlarging the thread title to something like 3 rem. We'll have more tweaking to get the visual hierarchy right but figuring out with selectors to use and doing the first round of styling is more than half the battle.

[DavidScottBernstein]

@rgilman I'm having a lot of fun! :)

[iangilman]

This is looking good, but one other thing @rgilman mentioned in https://github.com/ContextInstitute/bfcom/issues/50 is tightening up the spacing around the thread title. Right now it has top and bottom margins of 1em, which are especially large with the font size of 3rem. You should be able to slim that down by giving it margin: 0. Note that the margins are currently applied with the awfully specific selector:

body.buddypress .buddypress-wrap h3

... so you'll probably need to insert some of those classes into your selector so that it becomes specific enough.

I figure that might as well happen in this patch. Sound fair?

[DavidScottBernstein]

Can I simply add margin: 0; to my #item-body h3 style? When I add the selectors body.buddypress and/or .buddypress-wrap they don't seem to make any difference. The same h3 tags on the other pages get a zero margins but that looks better when the font is big. Is there a page with an h3 that you don't want to have a margin of zero that I can test against?

Also, how do I find this thread on GitHub so I can reply there instead of replying to the email?

Thank you, David.

PS. I’m planning to be away most of today.

On Oct 19, 2018, at 9:50 AM, Ian Gilman notifications@github.com wrote:

This is looking good, but one other thing @rgilman https://github.com/rgilman mentioned in #50 https://github.com/ContextInstitute/bfcom/issues/50 is tightening up the spacing around the thread title. Right now it has top and bottom margins of 1em, which are especially large with the font size of 3rem. You should be able to slim that down by giving it margin: 0. Note that the margins are currently applied with the awfully specific selector:

body.buddypress .buddypress-wrap h3

... so you'll probably need to insert some of those classes into your selector so that it becomes specific enough.

I figure that might as well happen in this patch. Sound fair?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ContextInstitute/bfcom/pull/65#issuecomment-431427232, or mute the thread https://github.com/notifications/unsubscribe-auth/AGxlMrYzr2dY5EA_lRrgg3nictWf5Fr-ks5umgLdgaJpZM4XvQvT.

David Scott Bernstein, David@ToBeAgile.com Developer/Speaker/Trainer/Coach. Principal consultant at To Be Agile http://tobeagile.com/. Author of Beyond Legacy Code: Nine Practices to Extend the Life (and Value) of Your Software http://beyondlegacycode.com/. Stay in touch: sign up for my newsletter https://tobeagile.com/signup/, follow me on Twitter: @ToBeAgile http://twitter.com/ToBeAgile.

[DavidScottBernstein]

This change of adding margin: 0 to the #item-body h3 style might be hard to visualize so I've added it to my pull request so you can see it in action. Let me know if you want it changed.

[iangilman]

Yep, looks great! I mentioned the body.buddypress .buddypress-wrap stuff because I was concerned that just #item-body wouldn't be specific enough, but I guess it is! Probably because it's an ID rather than a class.

Thank you for making that change; it looks like this is ready to land, with one super minor issue: The margin line is indented using spaces, while the rest of the lines of the file are indented using tabs. Any thoughts on how that happened? Do you have EditorConfig hooked up?

[iangilman]

Oh, and to answer your other question, there should be a "View it on GitHub" link at the bottom of every notification email you get. Click on that and it'll take you right to the web page for the comment you got.

[DavidScottBernstein]

I might have typed 4 spaces instead of a tab. Looking at David16 on line 463 of style.css it looks like a tab is there now.

[iangilman]

Yeah, it can be hard to tell sometimes. I've gone ahead and fixed it, and now I'm merging this patch!