search

ContextInstitute / bfcom

http://bfn.context.org
GNU General Public License v3.0
4 stars 1 forks source link

David17: Removed light grey background on odd posts and added dividing line between posts. #68

Closed DavidScottBernstein closed 5 years ago

DavidScottBernstein commented 5 years ago

Fixed #51 to frame posts, removed the grey background on every odd post.

DavidScottBernstein commented 5 years ago

@iangilman I put the post styles #bbpress-forums div.odd and div.even at the bottom of the posts and content styles section. Let me know if you prefer it live somewhere else.

DavidScottBernstein commented 5 years ago

@robert This pull request (David17) removed the grey background on every other post and added a 1px line to divide posts. We can make it a tad softer by lightening up the shade a bit if you like.

rgilman commented 5 years ago

@DavidScottBernstein, great! I expect that #ccc will be fine for now. The goal is for the line to be unobtrusive but also strong enough so that when your eye gets to that part of the flow of conversation, you are cued into the break. If #ccc feels like that to you, let's go with it.

DavidScottBernstein commented 5 years ago

Yes, sounds good.

iangilman commented 5 years ago

I was imagining we would keep all of our BFCOM-specific styles below this marker in style.css:

/*********************/
/*    BFCom styles   */
/*********************/

That way they don't get mixed up with the styles we inherited. What do you think @DavidScottBernstein, @rgilman?

The change looks good, but I'm noticing the #ccc border between the posts is darker than the #eee border around the posts (which comes from .bbp-replies). I figure they should match, so one or the other should change. I personally like #eee but perhaps it's a little too light for some of our audience... What do you guys think? I suppose there's always #ddd in the middle.

DavidScottBernstein commented 5 years ago

@iangilman I changed the post dividing line color to #ddd (#eee seemed too dark) and move the code to the bottom of Style.css in a new section called FORUMS. I added this to the David17 branch.

iangilman commented 5 years ago

Looks good, thank you! A possible follow-up would be to update the border on .bbp-replies to #ddd so they match. BTW, when you say "darker" I assume you mean lighter? :-)