search

ContextLab / hypertools

A Python toolbox for gaining geometric insights into high-dimensional data
http://hypertools.readthedocs.io/en/latest/
MIT License
1.83k stars 160 forks source link

specify plot styles #2

Closed jeremymanning closed 7 years ago

jeremymanning commented 8 years ago

Feature request: in plot_coords.py, add ability to assign multiple plot styles to a list of trajectories (like MATLAB version)

jeremymanning commented 8 years ago

Calls like this should work: plot_coords((a, b), ('k.', 'bo'))

I'm not sure how to deal with keyword arguments...for example, what happens in the example below?

plot_coords((a, b), 'o', color=((0, 0, 1), (0, 1, 0)))

or should it be

plot_coords((a, b), 'o', (color=(0, 0, 1), color=(0, 1, 0)))

?

jeremymanning commented 8 years ago

@andrewheusser-- bringing you into this in case you have insights or suggestions...

andrewheusser commented 8 years ago

@jeremymanning @KirstensGitHub working on this today!

andrewheusser commented 8 years ago

i've been working on this feature today.

we should make a decision about specifying colors and linestyles together, or separately. if its separately, the colors arg can be a color name (e.g. k), a hex code or rgb tuple (triple?).

If its together (e.g. 'k--'), that makes the parsing a bit messier.

My opinion is that it would be cleanest to pass them separately, a colors list and a linestyles list.

thoughts? @jeremymanning @KirstensGitHub

KirstensGitHub commented 7 years ago

I think @andrewheusser resolved this issue last week?

jeremymanning commented 7 years ago

@andrewheusser -- has this issue been addressed? if so, please close it. (or, if not, please give a status update.)

andrewheusser commented 7 years ago

yep! this is working, merged into master and the api is documented. sorry, forgot to close this issue. closing now