Fix missing_inds tests - Githubissues

ContextLab / hypertools

A Python toolbox for gaining geometric insights into high-dimensional data

http://hypertools.readthedocs.io/en/latest/

MIT License

1.83k stars 160 forks source link

Fix missing_inds tests #202

Closed dwillmer closed 4 years ago

dwillmer commented 6 years ago

The assertions were failing because of the array == comparison.

Here we use numpy.testing.assert_array_equal to ensure the results are correct, and also test the list-of-arrays case. Gives 100% coverage of missing_inds.py

jeremymanning commented 4 years ago

I'm closing this pull request-- I agree that we need better tests, but too much has changed since this pull request was made. I've added this issue as a reminder that this still needs addressing.