bug fix for passing dict of options to reduce

ContextLab / hypertools

A Python toolbox for gaining geometric insights into high-dimensional data

http://hypertools.readthedocs.io/en/latest/

MIT License

1.81k stars 161 forks source link

bug fix for passing dict of options to reduce #228

Closed paxtonfitzpatrick closed 4 years ago

paxtonfitzpatrick commented 4 years ago

this PR fixes #216 and fixes #226.

changes to reduce.py:

fix issue with custom params dict being overwritten
as a result, added a new warning for multiple values passed via ndims and n_components
moved some fail conditions earlier in the code
added step to check whether or not model is a supported option & a custom error message if it's not
added (limited, low-risk) option to pass custom reducer models, both with & without a custom param dict
added new related error condition (if custom model doesn't support minimum necessary methods)
minor code cleanup

other changes:

updated depreciated pandas.DataFrame method in df2mat.py

paxtonfitzpatrick commented 4 years ago

btw, Travis seems to be failing due to this issue rather than problem in code

paxtonfitzpatrick commented 4 years ago

@jeremymanning This is ready to merge in! The README already contains instructions for addressing the deepdish/hdf5/pytables issue I was encountering with the python 3.5 build, so that's set. As for dropping support for 2.7, it's possible to set which version is installed based on python distro version in the configuration for pypi. However, I'm not sure that's worth it given that we're ~2 weeks from 2.7's EOL and pypi is phasing out support for it anyway.

paxtonfitzpatrick commented 4 years ago

agh, hang on, gotta update some files for the new release version first

paxtonfitzpatrick commented 4 years ago

added a unit test for the bug fix.

The test's format breaks from the simple two-line format of the others in test_reduce.py, but this is somewhat necessary to ensure the test operates properly.
Also had to run test on a different array from the rest of the reduce tests, since the default array is too small and raises a ValueError for UMAP.

jeremymanning commented 4 years ago

this will become release 0.6.0...

jeremymanning commented 4 years ago

removes support for python 2.x and 3.5