point_colors takes a really long time on large datasets

ContextLab / hypertools

A Python toolbox for gaining geometric insights into high-dimensional data

http://hypertools.readthedocs.io/en/latest/

MIT License

1.83k stars 160 forks source link

point_colors takes a really long time on large datasets #37

Closed andrewheusser closed 7 years ago

andrewheusser commented 7 years ago

I was trying to plot a dataset with ~8,000 rows and it seemed to get hung up on val2colors during the ranking of the data: ranks = list(map(lambda x: sum([val <= x for val in vals]),vals))

I think this is because val2colors is automatically called if type(point_colors) is numeric. If I pass string labels, the operation is super quick. Thoughts on how t deal with this?

jeremymanning commented 7 years ago

is this resolved? if not, can you post some example code where this is an issue?

andrewheusser commented 7 years ago

working on this now, crashes with our new code due to a typecasting issue

andrewheusser commented 7 years ago

should be fixed now