search

ContextLab / hypertools

A Python toolbox for gaining geometric insights into high-dimensional data
http://hypertools.readthedocs.io/en/latest/
MIT License
1.83k stars 160 forks source link

Rewrite plot_1to2_list function? #8

Closed andrewheusser closed 7 years ago

andrewheusser commented 8 years ago

in plot_coords.py, lines 151-159, what is the purpose of plot_1to2_list?

@KirstensGitHub can you clarify, and if we aren't using it remove it from the code? Thanks!

KirstensGitHub commented 8 years ago

hi @andrewheusser ! You can see that plot1to2_list is called in the plot1D_list function.

Originally, plot1D just gave a 1D representation (a bar chart, I think) but we later decided to add a second dimension to any 1D data (variable x, hstack, etc) and to plot the data as a line graph

KirstensGitHub commented 7 years ago

Hi @andrewheusser and @jeremymanning should I close this issue?

jeremymanning commented 7 years ago

i'm closing this issue. however, before releasing we'll need to do a code cleanup-- the name of that function doesn't make it obvious what the function does. plus, we should have some consistency with our function names. i'll open a new issue specifically related to general code cleanup.