Fixing nii -> bo -> nii conversion; dropping support for python 2.7

ContextLab / supereeg

Infer activity throughout the brain from a small(ish) number of electrodes using Gaussian process regression

Other

34 stars 14 forks source link

Fixing nii -> bo -> nii conversion; dropping support for python 2.7 #207

Closed tmuntianu closed 3 years ago

tmuntianu commented 3 years ago

In order to get nii -> bo -> nii and bo -> nii -> bo conversions both working, added a from .bo flag in the Nifti header's descrip to be able to handle both cases. Am still not sure why this is necessary, since all of the affine transformations check out.

Also dropped support for 2.7 in both the readme and the Travis tests; skipping all GPU tests when there is no GPU or CuPy available.

lucywowen commented 3 years ago

Looks good to me!

tmuntianu commented 3 years ago

@jeremymanning can we merge this? would be good to get a new pip release going too, esp before cosyne

jeremymanning commented 3 years ago

@tmuntianu I'm so sorry i missed this-- @lucywowen can you check it over also? Seems good to me...

jeremymanning commented 3 years ago

merged since it looks like Lucy has already signed off.

jeremymanning commented 3 years ago

should we update pip?