search

ContextLab / timecorr

Estimate dynamic high-order correlations in multivariate timeseries data
MIT License
38 stars 11 forks source link

consistent params for timecorr #93

Open lucywowen opened 5 years ago

lucywowen commented 5 years ago

For some parameters (rfun) you pass a string, but for other paramters (cfun, combine, weights_fun, etc.) you pass a function. Should we discuss this?

jeremymanning commented 5 years ago

hmm...yes, we should probably discuss this...

ideally we could support either strings or functions for each thing. one approach might be to have a dictionary whose keys are the string names of functions and whose values are functions. then if the user passes a string, we could convert it to the associated function by looking up that key's value in the dictionary.

proposed plan:

  1. i'm happy to discuss; let me know if/when you'd like to do that
  2. i'm ok with proceeding with the current API if it's functional, and then keeping this issue open to deal with in a future release
jeremymanning commented 5 years ago

status of this? should we deal with this in a future release? @lucywowen