search

ContinualAI / avalanche

Avalanche: an End-to-End Library for Continual Learning based on PyTorch.
http://avalanche.continualai.org
MIT License
1.79k stars 291 forks source link

Refactoring needed in 'Without Avalanche' on Avalanche homepage #860

Closed zalakbhalani closed 2 years ago

zalakbhalani commented 2 years ago 
    train_data_loader = DataLoader(
        train_dataset, num_workers=num_workers, batch_size=train_mb_size)
    correct = 0
    for iteration, (test_mb_x, test_mb_y) in enumerate(test_data_loader):

There is a mistake in Gitbook in Without Avalanche tab. We need to replace train with test in these lines.

Here are reference lines from the Gitbook README.md file. https://github.com/ContinualAI/avalanche/blob/b6e9239c1780d3847276cdae5bc8c21deae660af/docs/gitbook/README.md?plain=1#L183

https://github.com/ContinualAI/avalanche/blob/b6e9239c1780d3847276cdae5bc8c21deae660af/docs/gitbook/README.md?plain=1#L179

vlomonaco commented 2 years ago

Thanks @zalakbhalani for reporting it! We'll fix it asap!

zalakbhalani commented 2 years ago

I may help you with fixing that. Can you assign this issue to me?