search

ContinuumIO / ProtoCI

Prototype of CI for conda recipes
BSD 3-Clause "New" or "Revised" License
7 stars 9 forks source link

avoid error when no changes to commit in target path's git #16

Closed PeterDSteinberg closed 8 years ago

PeterDSteinberg commented 8 years ago

When submitting packages with build2.py and in the part of the script that does a git commit in the submitted dir, I was encountering an error with subprocess.check_output if there were no diffs to commit. (Git returns non-zero exit code if there are no changes to commit). I fixed this issue by converting that check_output to a Popen call.

msarahan commented 8 years ago

+1 - git commit failures are not really build failures.