search

ContinuumIO / ciocheck

Continuum Analytics linter, formatter and test suite helper.
MIT License
25 stars 10 forks source link

PR: Invert order git diff blobs in commited mode #31

Closed rlaverde closed 7 years ago

rlaverde commented 7 years ago

Fixes: #29

As the comparison was inverted, git diff was returning deleted and modified lines, instead of added and modified lines.

goanpeca commented 7 years ago

Awesome thanks for the fix @rlaverde

goanpeca commented 7 years ago

So you could test it, I mean the change fixes the problem??

rlaverde commented 7 years ago

I was wrong this line have no errors, I misunderstood the --branch option, sorry :disappointed: I'll continue looking for a solution to this error.