search

ContinuumIO / flask-ldap-login

Flask ldap integration
BSD 2-Clause "Simplified" License
105 stars 35 forks source link

explicit absolute and relative imports #27

Open stephane-martin opened 8 years ago

stephane-martin commented 8 years ago

Lack of absolute imports can lead to ImportError in projects that use flask-ldap-login.

For example, if myproject has a ldap.py module and includes flask-ldap-login, the import ldapin flask_ldap_login/forms.py can lead to ambiguous imports in myproject.

The pull request just adds from __future__ import absolute_import to flask-ldap-login so that it does not happen anymore.

Thanks ! Stephane